Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify what's new to go to the changelog #19985

Merged
merged 6 commits into from
Jan 30, 2024
Merged

fix: Unify what's new to go to the changelog #19985

merged 6 commits into from
Jan 30, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Jan 26, 2024

Problem

Closes #19948

Changes

  • Fixes the account popover button to open the right page
  • Fixes not opening the right place if the docs panel wasn't already open
  • Remove / replace the side panel "whats new" 3000 stuff.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@benjackwhite benjackwhite requested a review from Twixes January 26, 2024 13:58
@benjackwhite benjackwhite changed the title fix: Opening of a docs link via state fix: Unify what's new to go to the changelog Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.22 MB

compressed-size-action

@benjackwhite benjackwhite requested a review from Twixes January 26, 2024 15:06
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty much it, thanks!

@Twixes Twixes enabled auto-merge (squash) January 30, 2024 15:07
@Twixes Twixes merged commit 5ad5811 into master Jan 30, 2024
79 checks passed
@Twixes Twixes deleted the fix/whats-new branch January 30, 2024 15:23
thmsobrmlr pushed a commit that referenced this pull request Feb 1, 2024
* fix: Opening of a docs link via state

* Fix

* Removed old assets

* Fix mobile experience

---------

Co-authored-by: Michael Matloka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: We have two new What's New buttons that do different things
2 participants